Inputing characters into arrays in C- follow up -

-

This is a follow-up question to a previous question which I asked about calculating a straight hand ... not the same. .. This is the way to read in the card - it works - but this is a better way - to use console input in C. ... 

  zero read_cards (int num_in_rank [], Int num_in_suit []) {bool card_exists [NUM_RANKS] [NUM_SUITS]; Four f, rank_text, suit_tech; Int rank, suit; Bull badcard; Int card_read = 0; {Num_in_rank [rank] = 0; for (rank = 0; rank & lt; NUM_RANKS; rank ++); (Suite = 0; Suit & lt; NUM_SUITS; Suit ++) [ranks] [suit] = Wrong for card_exists; } (Suite = 0; Suit & Lt; NUM_SUITS; Suit ++) num_in_suit [Suite] = 0; While (card_read and lt; NUM_CARDS) {bad_card = false; Printf ("Enter a Card:"); Rank_click = by (); Switch (rank_ch) {case '0': exit (EXIT_SUCCESS); Case '2': Rank = 0; break; Case '3': Rank = 1; break; Case '4': Rank = 2; break; Case '5': Rank = 3; break; Case '6': Rank = 4; break; Case '7': Rank = 5; break; Case '8': Rank = 6; break; Case '9': Rank = 7; break; Case 'T': Case 'T': Rank = 8; break; Case 'J': Case 'J': Rank = 9; break; Case 'Q': Case 'Q': Rank = 10; break; Case 'A': Case 'K': Rank = 11; break; Case 'A': Case 'A': Rank = 12; break; Default: bad_card = true; } Suit_ch = meet (); Switch (suit_ch) {case 'C': case 'C': Suit = 0; break; Case 'D': Case 'D': Suit = 1; break; Case 'H': Case 'H': Suit = 2; break; Of the case ': case' s': suit = 3; break; Default: bad_card = true; } While ((ch = getchar ())! = '\ N') if (ch! = '') Bad_card = true; If (bad_card) printf ("bad card, Ignored. \ N"); And if (card_exist [rank] [suit]) printf ("duplicate card, neglected. \ N"); Else {num_in_rank [rank] ++; Num_in_suit [suite] ++; Card_exists [rank] [suite] = true; Cards_read ++; }}}

I know that there may be some customization in the case statement - like Using Toupper; Better card value, etc. Suggestion - Please reflect the code C99 ...

The code looks ok to me Has been quite well and readable in my opinion.

It seems that you are asking about optimization - unless you are sure that you need it, otherwise it is less edible than your text and more bugs. Specifically, this function is going to spend more than 99.99%, which is waiting for the user to type now, so there is no need to customize it.

I do not think it is necessary to use the fall-thru to hold both upper and lowercase inputs in the switch statement, especially if you have some cases with just a few more Is typing.

If this is indeed an issue with code and whether it is not compiling or not, then what is this, please describe the problem.

Edit: The only thing you want to change is to get rid of the obvious cases for the 0-9 rank, and instead in the case of the body, all of them combine in the same fall: 

  rank = rank_ch - 0 ';

This is a relatively common idiom for converting a stored number in the form of a character, so it should be readable to other programmers.


Comments

Post a Comment

Popular posts from this blog

c++ - Linux and clipboard -

-
After selecting the copies of the buffer in Linux, after the text, we can click and paste the button between the mouse. I think there is a special buffer for this, I want to use it. Programming Language: C ++ Your Library: Qt Thanks. There is just one more correct answer than Paul Dixon, which answers your needs: / P > QClipboard * clipboard = QApplication :: clipboard (); CastString Selected Text = Clipboard-> Text (QClipboard :: Selection);
Read more

What is expire header and how to achive them in ASP.NET and PHP? -

-
I have examined the performance statistics of my website today. I have received a warning (or error may occur) that is given below Add Terminal Headers Here are 15 static components without a 15-futures end date * (no end) Http://www.example.com/video/css/global.css * (no time limit) http://www.example.com/video/js/global.js * (no expiration ) Http: //www.example.com/video/images/main-bg.png what it means and how to achieve it both in PHP and ASP.Net. I am on a shared hosting server, so please tell me some ways to use the code, because I can not make any modifications at the end of the server. If I expire the header, then there is no chance that if I make changes to the CSS, then the user will not be able to remove them immediately because CSS and other files have a fixed time limit (1 month, week ) Are cached for. Is Is there any harm to using PHP? $ time = time () + 3 * 24 * 60 * 60; // 3 day headings ('End:'. GMDAT ('D, D MYH: i: s \ g \ m \ t',
Read more

sql server - How can I determine which of my SQL 2005 statistics are unused? -

-
After a few years, one of my biggest databases has deposited 73 figures out of its largest tables. With Indexes, I can run many types of reports and queries, how often / heavily specific indexes are used. What is an equivalent for data? We are running SQL 2005. To make statistics automatically managed and honest, I would like to "update statistics", "create statistics" and There is no information about any management except "drop statistics" orders. In theory, UPDATE should handle the addition and removal of statistical data. In addition, I've never heard about the amount of storage or storage taking in large amounts, so I'm not sure whether there is any reason for the alarm or not. If you are seeing a potential problem, then I would suggest running an update before, if it does not clean it, it is leaving and then it appears to be safe operation (because it is the only query optimizer Is for). I will not leave "left" in the
Read more